Skip to content

Add time duration methods #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add time duration methods #2146

wants to merge 4 commits into from
+187 −0

Conversation

@h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Nov 24, 2025 •
edited
Loading

Motivation

Previously discussed in slack. One difficulty that users have when building an NWBFile is to understand the overall time organization of the data. There is a push for providing better reporting of this and these methods would be useful in this context.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Nov 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.28%. Comparing base (293af8c) to head (d25689e).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2146      +/-   ##
==========================================
+ Coverage   95.23%   95.28%   +0.04%     
==========================================
  Files          29       29              
  Lines        2876     2905      +29     
  Branches      740      748       +8     
==========================================
+ Hits         2739     2768      +29     
  Misses         83       83              
  Partials       54       54
Flag Coverage Δ
integration 73.87% <17.24%> (-0.58%) ⬇️
unit 85.09% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendichter
Copy link
Contributor

bendichter commented Nov 25, 2025

This looks great to me, thanks for working on this, @h-mayorquin ! I'd be interested in @oruebel 's thoughts as well

oruebel
oruebel reviewed Nov 25, 2025
View reviewed changes
oruebel
oruebel reviewed Nov 25, 2025
View reviewed changes
oruebel
oruebel reviewed Nov 25, 2025
View reviewed changes
@oruebel
Copy link
Contributor

oruebel commented Nov 25, 2025

I'd be interested in @oruebel 's thoughts as well

This is looks overall good to me. I added a few small suggestions, but overall this seems fine to me. I'll let @stephprince do final review and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oruebel oruebel oruebel left review comments

@bendichter bendichter Awaiting requested review from bendichter

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h-mayorquin @bendichter @oruebel